index.xml 8.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171
  1. <?xml version="1.0" encoding="utf-8" standalone="yes" ?>
  2. <rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">
  3. <channel>
  4. <title>Contributings on Laradock Docs</title>
  5. <link>http://laradock.io/contributing/index.xml</link>
  6. <description>Recent content in Contributings on Laradock Docs</description>
  7. <generator>Hugo -- gohugo.io</generator>
  8. <language>en-us</language>
  9. <atom:link href="http://laradock.io/contributing/index.xml" rel="self" type="application/rss+xml" />
  10. <item>
  11. <title>Contributing</title>
  12. <link>http://laradock.io/contributing/</link>
  13. <pubDate>Mon, 01 Jan 0001 00:00:00 +0000</pubDate>
  14. <guid>http://laradock.io/contributing/</guid>
  15. <description>
  16. &lt;h2 id=&#34;guidelines:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Guidelines&lt;/h2&gt;
  17. &lt;p&gt;Your contribution is more than welcome.&lt;/p&gt;
  18. &lt;h3 id=&#34;got-a-question-or-problem:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Got a Question or Problem?&lt;/h3&gt;
  19. &lt;p&gt;If you have questions about how to use LaraDock, please direct your questions to the discussion on &lt;a href=&#34;https://gitter.im/LaraDock/laradock&#34;&gt;Gitter&lt;/a&gt;. If you believe your question could help others, then consider opening an &lt;a href=&#34;https://github.com/laradock/laradock/issues&#34;&gt;Issue&lt;/a&gt; (it will be labeled as Question).&lt;/p&gt;
  20. &lt;h3 id=&#34;found-an-issue:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Found an Issue?&lt;/h3&gt;
  21. &lt;p&gt;If you find a bug in the source code or a mistake in the documentation, you can help us by
  22. submitting an &lt;a href=&#34;https://github.com/laradock/laradock/issues&#34;&gt;Issue&lt;/a&gt;. Even better you can submit a Pull Request with a fix.&lt;/p&gt;
  23. &lt;h3 id=&#34;want-a-feature:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Want a Feature?&lt;/h3&gt;
  24. &lt;p&gt;You can request a new feature by submitting an &lt;a href=&#34;https://github.com/laradock/laradock/issues&#34;&gt;Issue&lt;/a&gt; (it will be labeled as Feature Suggestion). If you would like to implement a new feature then consider submitting a Pull Request.&lt;/p&gt;
  25. &lt;h2 id=&#34;coding-guidelines:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Coding Guidelines&lt;/h2&gt;
  26. &lt;h3 id=&#34;support-new-software:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Support new Software&lt;/h3&gt;
  27. &lt;ul&gt;
  28. &lt;li&gt;&lt;p&gt;Create folder with the software name.&lt;/p&gt;&lt;/li&gt;
  29. &lt;li&gt;&lt;p&gt;Add a &lt;code&gt;Dockerfile&lt;/code&gt;, write your code there.&lt;/p&gt;&lt;/li&gt;
  30. &lt;li&gt;&lt;p&gt;You may add additional files in the software folder.&lt;/p&gt;&lt;/li&gt;
  31. &lt;li&gt;&lt;p&gt;Add the software to the &lt;code&gt;docker-compose.yml&lt;/code&gt; file.&lt;/p&gt;&lt;/li&gt;
  32. &lt;li&gt;&lt;p&gt;Make sure you follow our commenting style.&lt;/p&gt;&lt;/li&gt;
  33. &lt;li&gt;&lt;p&gt;Add the software in the &lt;code&gt;Readme&lt;/code&gt;.&lt;/p&gt;&lt;/li&gt;
  34. &lt;/ul&gt;
  35. &lt;h3 id=&#34;edit-existing-software:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Edit existing Software&lt;/h3&gt;
  36. &lt;ul&gt;
  37. &lt;li&gt;&lt;p&gt;Open the software (container) folder.&lt;/p&gt;&lt;/li&gt;
  38. &lt;li&gt;&lt;p&gt;Edit the files you want to update.&lt;/p&gt;&lt;/li&gt;
  39. &lt;li&gt;&lt;p&gt;&lt;strong&gt;Note:&lt;/strong&gt; If you want to edit the base image of the &lt;code&gt;Workspace&lt;/code&gt; or the &lt;code&gt;php-fpm&lt;/code&gt; Containers,
  40. you need to edit their Dockerfiles from their GitHub repositories. For more info read their Dockerfiles comment on the LaraDock repository.&lt;/p&gt;&lt;/li&gt;
  41. &lt;li&gt;&lt;p&gt;Make sure to update the &lt;code&gt;Readme&lt;/code&gt; in case you made any changes.&lt;/p&gt;&lt;/li&gt;
  42. &lt;/ul&gt;
  43. &lt;h2 id=&#34;issue-pr-submission-guidelines:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Issue/PR Submission Guidelines&lt;/h2&gt;
  44. &lt;h3 id=&#34;submitting-an-issue:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Submitting an Issue&lt;/h3&gt;
  45. &lt;p&gt;Before you submit your issue search the archive, maybe your question was already answered.&lt;/p&gt;
  46. &lt;p&gt;If your issue appears to be a bug, and hasn&#39;t been reported, open a new issue.
  47. Help us to maximize the effort we can spend fixing issues and adding new
  48. features, by not reporting duplicate issues.&lt;/p&gt;
  49. &lt;h3 id=&#34;before-submitting-a-pull-request-pr:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Before Submitting a Pull Request (PR)&lt;/h3&gt;
  50. &lt;p&gt;Always Test everything and make sure its working:&lt;/p&gt;
  51. &lt;ul&gt;
  52. &lt;li&gt;Pull the latest updates (or fork of you don’t have permission)&lt;/li&gt;
  53. &lt;li&gt;Before editing anything:
  54. &lt;ul&gt;
  55. &lt;li&gt;Test building the container (docker-compose build --no-cache container-name) build with no cache first.&lt;/li&gt;
  56. &lt;li&gt;Test running the container with some other containers in real app and see of everything is working fine.&lt;/li&gt;
  57. &lt;/ul&gt;&lt;/li&gt;
  58. &lt;li&gt;Now edit the container (edit section by section and test rebuilding the container after every edited section)
  59. &lt;ul&gt;
  60. &lt;li&gt;Testing building the container (docker-compose build container-name) with no errors.&lt;/li&gt;
  61. &lt;li&gt;Test it in real App.&lt;/li&gt;
  62. &lt;/ul&gt;&lt;/li&gt;
  63. &lt;/ul&gt;
  64. &lt;h3 id=&#34;submitting-a-pr:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Submitting a PR&lt;/h3&gt;
  65. &lt;p&gt;Consider the following guidelines:&lt;/p&gt;
  66. &lt;ul&gt;
  67. &lt;li&gt;&lt;p&gt;Search &lt;a href=&#34;https://github.com/laradock/laradock/pulls&#34;&gt;GitHub&lt;/a&gt; for an open or closed Pull Request that relates to your submission. You don&#39;t want to duplicate effort.&lt;/p&gt;&lt;/li&gt;
  68. &lt;li&gt;&lt;p&gt;Make your changes in a new git branch:&lt;/p&gt;
  69. &lt;pre&gt;&lt;code class=&#34;language-shell&#34;&gt; git checkout -b my-fix-branch master
  70. &lt;/code&gt;&lt;/pre&gt;&lt;/li&gt;
  71. &lt;li&gt;&lt;p&gt;Commit your changes using a descriptive commit message.&lt;/p&gt;&lt;/li&gt;
  72. &lt;li&gt;&lt;p&gt;Push your branch to GitHub:&lt;/p&gt;
  73. &lt;pre&gt;&lt;code class=&#34;language-shell&#34;&gt;git push origin my-fix-branch
  74. &lt;/code&gt;&lt;/pre&gt;&lt;/li&gt;
  75. &lt;li&gt;&lt;p&gt;In GitHub, send a pull request to &lt;code&gt;laradock:master&lt;/code&gt;.&lt;/p&gt;&lt;/li&gt;
  76. &lt;li&gt;&lt;p&gt;If we suggest changes then:&lt;/p&gt;
  77. &lt;ul&gt;
  78. &lt;li&gt;Make the required updates.&lt;/li&gt;
  79. &lt;li&gt;Commit your changes to your branch (e.g. &lt;code&gt;my-fix-branch&lt;/code&gt;).&lt;/li&gt;
  80. &lt;li&gt;Push the changes to your GitHub repository (this will update your Pull Request).&lt;/li&gt;
  81. &lt;/ul&gt;&lt;/li&gt;
  82. &lt;/ul&gt;
  83. &lt;blockquote&gt;
  84. &lt;p&gt;If the PR gets too outdated we may ask you to rebase and force push to update the PR:&lt;/p&gt;
  85. &lt;/blockquote&gt;
  86. &lt;pre&gt;&lt;code class=&#34;language-shell&#34;&gt;git rebase master -i
  87. git push origin my-fix-branch -f
  88. &lt;/code&gt;&lt;/pre&gt;
  89. &lt;p&gt;&lt;em&gt;WARNING. Squashing or reverting commits and forced push thereafter may remove GitHub comments on code that were previously made by you and others in your commits.&lt;/em&gt;&lt;/p&gt;
  90. &lt;h3 id=&#34;after-your-pr-is-merged:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;After your PR is merged&lt;/h3&gt;
  91. &lt;p&gt;After your pull request is merged, you can safely delete your branch and pull the changes
  92. from the main (upstream) repository:&lt;/p&gt;
  93. &lt;ul&gt;
  94. &lt;li&gt;&lt;p&gt;Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:&lt;/p&gt;
  95. &lt;pre&gt;&lt;code class=&#34;language-shell&#34;&gt;git push origin --delete my-fix-branch
  96. &lt;/code&gt;&lt;/pre&gt;&lt;/li&gt;
  97. &lt;li&gt;&lt;p&gt;Check out the master branch:&lt;/p&gt;
  98. &lt;pre&gt;&lt;code class=&#34;language-shell&#34;&gt;git checkout master -f
  99. &lt;/code&gt;&lt;/pre&gt;&lt;/li&gt;
  100. &lt;li&gt;&lt;p&gt;Delete the local branch:&lt;/p&gt;
  101. &lt;pre&gt;&lt;code class=&#34;language-shell&#34;&gt;git branch -D my-fix-branch
  102. &lt;/code&gt;&lt;/pre&gt;&lt;/li&gt;
  103. &lt;li&gt;&lt;p&gt;Update your master with the latest upstream version:&lt;/p&gt;
  104. &lt;pre&gt;&lt;code class=&#34;language-shell&#34;&gt;git pull --ff upstream master
  105. &lt;/code&gt;&lt;/pre&gt;&lt;/li&gt;
  106. &lt;/ul&gt;
  107. &lt;p&gt;&lt;br&gt;&lt;/p&gt;
  108. &lt;h3 id=&#34;happy-coding:d680e8a854a7cbad6d490c445cba2eba&#34;&gt;Happy Coding :)&lt;/h3&gt;
  109. </description>
  110. </item>
  111. </channel>
  112. </rss>